ncurses 6.2 - patch 20200816

[ncurses.git] / ncurses / base / safe_sprintf.c

diff --git a/ncurses/base/safe_sprintf.c b/ncurses/base/safe_sprintf.c
index 283b3291081d4b54894688608454a12c2b19317b..1868c009660c37751f3c50153a1b7fead64e5f41 100644 (file)
--- a/ncurses/base/safe_sprintf.c
+++ b/ncurses/base/safe_sprintf.c
@@ -1,5 +1,6 @@
 /****************************************************************************
- * Copyright (c) 1998-2007,2009 Free Software Foundation, Inc.              *
+ * Copyright 2018,2020 Thomas E. Dickey                                     *
+ * Copyright 1998-2012,2013 Free Software Foundation, Inc.                  *
  *                                                                          *
  * Permission is hereby granted, free of charge, to any person obtaining a  *
  * copy of this software and associated documentation files (the            *
@@ -27,13 +28,13 @@
  ****************************************************************************/
 
 /****************************************************************************
- *  Author: Thomas E. Dickey <dickey@clark.net> 1997                        *
+ *  Author: Thomas E. Dickey        1997-on                                 *
  ****************************************************************************/
 
 #include <curses.priv.h>
 #include <ctype.h>
 
-MODULE_ID("$Id: safe_sprintf.c,v 1.22 2009/04/18 18:46:46 tom Exp $")
+MODULE_ID("$Id: safe_sprintf.c,v 1.33 2020/02/02 23:34:34 tom Exp $")
 
 #if USE_SAFE_SPRINTF
 
@@ -41,7 +42,7 @@ typedef enum {
     Flags, Width, Prec, Type, Format
 } PRINTF;
 
-#define VA_INTGR(type) ival = va_arg(ap, type)
+#define VA_INTGR(type) ival = (int) va_arg(ap, type)
 #define VA_FLOAT(type) fval = va_arg(ap, type)
 #define VA_POINT(type) pval = (void *)va_arg(ap, type)
 
@@ -109,12 +110,16 @@ _nc_printf_length(const char *fmt, va_list ap)
                    } else if (state == Prec) {
                        prec = ival;
                    }
-                   sprintf(fmt_arg, "%d", ival);
+                   _nc_SPRINTF(fmt_arg,
+                               _nc_SLIMIT(sizeof(fmt_arg))
+                               "%d", ival);
                    fmt_len += strlen(fmt_arg);
                    if ((format = _nc_doalloc(format, fmt_len)) == 0) {
+                       free(buffer);
                        return -1;
                    }
-                   strcpy(&format[--f], fmt_arg);
+                   --f;
+                   _nc_STRCPY(&format[f], fmt_arg, fmt_len - f);
                    f = strlen(format);
                } else if (isalpha(UChar(*fmt))) {
                    done = TRUE;
@@ -153,9 +158,9 @@ _nc_printf_length(const char *fmt, va_list ap)
                    case 's':
                        VA_POINT(char *);
                        if (prec < 0)
-                           prec = strlen(pval);
+                           prec = (int) strlen(pval);
                        if (prec > (int) length) {
-                           length = length + prec;
+                           length = length + (size_t) prec;
                            buffer = typeRealloc(char, length, buffer);
                            if (buffer == 0) {
                                free(format);
@@ -185,13 +190,13 @@ _nc_printf_length(const char *fmt, va_list ap)
            format[f] = '\0';
            switch (used) {
            case 'i':
-               sprintf(buffer, format, ival);
+               _nc_SPRINTF(buffer, _nc_SLIMIT(length) format, ival);
                break;
            case 'f':
-               sprintf(buffer, format, fval);
+               _nc_SPRINTF(buffer, _nc_SLIMIT(length) format, fval);
                break;
            default:
-               sprintf(buffer, format, pval);
+               _nc_SPRINTF(buffer, _nc_SLIMIT(length) format, pval);
                break;
            }
            len += (int) strlen(buffer);
@@ -220,12 +225,17 @@ NCURSES_SP_NAME(_nc_printf_string) (NCURSES_SP_DCLx
 {
     char *result = 0;
 
-    if (fmt != 0) {
+    if (SP_PARM != 0 && fmt != 0) {
 #if USE_SAFE_SPRINTF
-       int len = _nc_printf_length(fmt, ap);
+       va_list ap2;
+       int len;
+
+       begin_va_copy(ap2, ap);
+       len = _nc_printf_length(fmt, ap2);
+       end_va_copy(ap2);
 
        if ((int) my_length < len + 1) {
-           my_length = 2 * (len + 1);
+           my_length = (size_t) (2 * (len + 1));
            my_buffer = typeRealloc(char, my_length, my_buffer);
        }
        if (my_buffer != 0) {
@@ -244,15 +254,15 @@ NCURSES_SP_NAME(_nc_printf_string) (NCURSES_SP_DCLx
                MyRows = screen_lines(SP_PARM);
            if (screen_columns(SP_PARM) > MyCols)
                MyCols = screen_columns(SP_PARM);
-           my_length = (MyRows * (MyCols + 1)) + 1;
+           my_length = (size_t) (MyRows * (MyCols + 1)) + 1;
            my_buffer = typeRealloc(char, my_length, my_buffer);
        }
 
        if (my_buffer != 0) {
 # if HAVE_VSNPRINTF
-           vsnprintf(my_buffer, my_length, fmt, ap);   /* GNU extension */
+           vsnprintf(my_buffer, my_length, fmt, ap);   /* SUSv2, 1997 */
 # else
-           vsprintf(my_buffer, fmt, ap);       /* ANSI */
+           vsprintf(my_buffer, fmt, ap);       /* ISO/ANSI C, 1989 */
 # endif
            result = my_buffer;
        }