X-Git-Url: https://ncurses.scripts.mit.edu/?p=ncurses.git;a=blobdiff_plain;f=ncurses%2Ftinfo%2Falloc_entry.c;h=506fb386d208d914fca43142019317f593285693;hp=1496752f1956ec483b8f7674af61ba5d082d28e3;hb=d4d1d81ab6fc1ad681ff120d925099f947fefcf3;hpb=027ae42953e3186daed8f3882da73de48291b606

diff --git a/ncurses/tinfo/alloc_entry.c b/ncurses/tinfo/alloc_entry.c
index 1496752f..506fb386 100644
--- a/ncurses/tinfo/alloc_entry.c
+++ b/ncurses/tinfo/alloc_entry.c
@@ -1,5 +1,5 @@
 /****************************************************************************
- * Copyright (c) 1998-2005,2006 Free Software Foundation, Inc.              *
+ * Copyright (c) 1998-2008,2010 Free Software Foundation, Inc.              *
  *                                                                          *
  * Permission is hereby granted, free of charge, to any person obtaining a  *
  * copy of this software and associated documentation files (the            *
@@ -46,9 +46,8 @@
 #include <curses.priv.h>
 
 #include <tic.h>
-#include <term_entry.h>
 
-MODULE_ID("$Id: alloc_entry.c,v 1.47 2006/12/16 19:06:58 tom Exp $")
+MODULE_ID("$Id: alloc_entry.c,v 1.51 2010/12/25 23:06:01 tom Exp $")
 
 #define ABSENT_OFFSET    -1
 #define CANCELLED_OFFSET -2
@@ -65,8 +64,10 @@ _nc_init_entry(TERMTYPE *const tp)
     unsigned i;
 
 #if NO_LEAKS
-    if (tp == 0 && stringbuf != 0) {
-	FreeAndNull(stringbuf);
+    if (tp == 0) {
+	if (stringbuf != 0) {
+	    FreeAndNull(stringbuf);
+	}
 	return;
     }
 #endif
@@ -145,7 +146,8 @@ NCURSES_EXPORT(void)
 _nc_wrap_entry(ENTRY * const ep, bool copy_strings)
 /* copy the string parts to allocated storage, preserving pointers to it */
 {
-    int offsets[MAX_ENTRY_SIZE / 2], useoffsets[MAX_USES];
+    int offsets[MAX_ENTRY_SIZE / sizeof(short)];
+    int useoffsets[MAX_USES];
     unsigned i, n;
     unsigned nuses = ep->nuses;
     TERMTYPE *tp = &(ep->tterm);
@@ -171,21 +173,25 @@ _nc_wrap_entry(ENTRY * const ep, bool copy_strings)
 	free(tp->str_table);
     }
 
-    n = tp->term_names - stringbuf;
+    assert(tp->term_names >= stringbuf);
+    n = (unsigned) (tp->term_names - stringbuf);
     for_each_string(i, &(ep->tterm)) {
-	if (tp->Strings[i] == ABSENT_STRING)
-	    offsets[i] = ABSENT_OFFSET;
-	else if (tp->Strings[i] == CANCELLED_STRING)
-	    offsets[i] = CANCELLED_OFFSET;
-	else
-	    offsets[i] = tp->Strings[i] - stringbuf;
+	if (i < SIZEOF(offsets)) {
+	    if (tp->Strings[i] == ABSENT_STRING) {
+		offsets[i] = ABSENT_OFFSET;
+	    } else if (tp->Strings[i] == CANCELLED_STRING) {
+		offsets[i] = CANCELLED_OFFSET;
+	    } else {
+		offsets[i] = (int) (tp->Strings[i] - stringbuf);
+	    }
+	}
     }
 
     for (i = 0; i < nuses; i++) {
 	if (ep->uses[i].name == 0)
 	    useoffsets[i] = ABSENT_OFFSET;
 	else
-	    useoffsets[i] = ep->uses[i].name - stringbuf;
+	    useoffsets[i] = (int) (ep->uses[i].name - stringbuf);
     }
 
     if ((tp->str_table = typeMalloc(char, next_free)) == (char *) 0)
@@ -194,28 +200,33 @@ _nc_wrap_entry(ENTRY * const ep, bool copy_strings)
 
     tp->term_names = tp->str_table + n;
     for_each_string(i, &(ep->tterm)) {
-	if (offsets[i] == ABSENT_OFFSET)
-	    tp->Strings[i] = ABSENT_STRING;
-	else if (offsets[i] == CANCELLED_OFFSET)
-	    tp->Strings[i] = CANCELLED_STRING;
-	else
-	    tp->Strings[i] = tp->str_table + offsets[i];
+	if (i < SIZEOF(offsets)) {
+	    if (offsets[i] == ABSENT_OFFSET) {
+		tp->Strings[i] = ABSENT_STRING;
+	    } else if (offsets[i] == CANCELLED_OFFSET) {
+		tp->Strings[i] = CANCELLED_STRING;
+	    } else {
+		tp->Strings[i] = tp->str_table + offsets[i];
+	    }
+	}
     }
 
 #if NCURSES_XNAMES
     if (!copy_strings) {
-	if ((n = NUM_EXT_NAMES(tp)) != 0) {
-	    unsigned length = 0;
-	    for (i = 0; i < n; i++) {
-		length += strlen(tp->ext_Names[i]) + 1;
-		offsets[i] = tp->ext_Names[i] - stringbuf;
-	    }
-	    if ((tp->ext_str_table = typeMalloc(char, length)) == 0)
-		  _nc_err_abort(MSG_NO_MEMORY);
-	    for (i = 0, length = 0; i < n; i++) {
-		tp->ext_Names[i] = tp->ext_str_table + length;
-		strcpy(tp->ext_Names[i], stringbuf + offsets[i]);
-		length += strlen(tp->ext_Names[i]) + 1;
+	if ((n = (unsigned) NUM_EXT_NAMES(tp)) != 0) {
+	    if (n < SIZEOF(offsets)) {
+		size_t length = 0;
+		for (i = 0; i < n; i++) {
+		    length += strlen(tp->ext_Names[i]) + 1;
+		    offsets[i] = (int) (tp->ext_Names[i] - stringbuf);
+		}
+		if ((tp->ext_str_table = typeMalloc(char, length)) == 0)
+		      _nc_err_abort(MSG_NO_MEMORY);
+		for (i = 0, length = 0; i < n; i++) {
+		    tp->ext_Names[i] = tp->ext_str_table + length;
+		    strcpy(tp->ext_Names[i], stringbuf + offsets[i]);
+		    length += strlen(tp->ext_Names[i]) + 1;
+		}
 	    }
 	}
     }
@@ -245,13 +256,13 @@ _nc_merge_entry(TERMTYPE *const to, TERMTYPE *const from)
 	    if (mergebool == CANCELLED_BOOLEAN)
 		to->Booleans[i] = FALSE;
 	    else if (mergebool == TRUE)
-		to->Booleans[i] = mergebool;
+		to->Booleans[i] = (char) mergebool;
 	}
     }
 
     for_each_number(i, from) {
 	if (to->Numbers[i] != CANCELLED_NUMERIC) {
-	    int mergenum = from->Numbers[i];
+	    short mergenum = from->Numbers[i];
 
 	    if (mergenum == CANCELLED_NUMERIC)
 		to->Numbers[i] = ABSENT_NUMERIC;